This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Add Stop Grace Period to compatibility file.#2141
Open
WoodellJ wants to merge 2 commits intodocker-archive:mainfrom
Open
Add Stop Grace Period to compatibility file.#2141WoodellJ wants to merge 2 commits intodocker-archive:mainfrom
WoodellJ wants to merge 2 commits intodocker-archive:mainfrom
Conversation
This is already supported downstream but the compatibility file stops it.
Author
|
Anyone available to review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add support for sending stop grace period down the pipe. This is already supported downstream but the compatibility file stops it. Updated the docs to reflect both this change and the fact that service.labels works as well.