Adding the python scripts to create the machine learning / onnx model…#107
Merged
StephanieKemna merged 7 commits intomainfrom Oct 6, 2025
Merged
Adding the python scripts to create the machine learning / onnx model…#107StephanieKemna merged 7 commits intomainfrom
StephanieKemna merged 7 commits intomainfrom
Conversation
…s, including dataset, requirements, and instructions in the README
…es to fix/add type ignore
Collaborator
KristofferSkare
left a comment
There was a problem hiding this comment.
Looks like a good solution to get the code to generate the example onnx files/models into the repo. I think it should be fine just like this since the code seems unmodified.
However, I am a bit unsure if we should add the data used to train the model to the repo since it is pretty easy to download for the user, and this is a bit of a niche thing most users will not do. I think that is the only thing missing before I approve
KristofferSkare
approved these changes
Oct 3, 2025
Collaborator
KristofferSkare
left a comment
There was a problem hiding this comment.
Approve as my only comment was discussed and resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s, including dataset, requirements, and instructions in the README
Description
Resolves #104
Added Python code and instructions for creating the keras and onnx models, for the examples in this repo. The split is a bit different from the other repo, I stuck to the structure here, so there are 2 separate train_model scripts, in each model folder. The utils.py is placed in the examples folder, so both folders/model creation scripts can access it.
Instructions are added to the README in the examples folder, and there is also a requirements file to get the correct packages.
How Has This Been Tested?
Following the instructions I added to README.md, I:
Developer Checklist (before requesting PR review)
I have:
Reviewer checklist
I have: