Skip to content

GP evaluation#134

Open
vatsgo wants to merge 2 commits intomainfrom
feature/GP-Evaluation
Open

GP evaluation#134
vatsgo wants to merge 2 commits intomainfrom
feature/GP-Evaluation

Conversation

@vatsgo
Copy link
Copy Markdown
Collaborator

@vatsgo vatsgo commented Mar 25, 2026

Evaluation pf the GP quality.

Added the GP evaluation for the North sea wave crest heights use case.
The Nootebook describes the assumptions as well as how to interpret the results. A summary of the plots is here :

loo_results_30_points

@vatsgo vatsgo requested a review from am-kaiser March 26, 2026 07:37
Copy link
Copy Markdown
Collaborator

@am-kaiser am-kaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my review I have stayed on high level perspective so far and haven't yet looked at the code in detail. @swinter1 will take over from here.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description of what you are doing and why at the top of the notebook. The idea is that someone else who is reading this in 1 year still understands what is going on.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify what all variables mean, e.g. X, Y, theta.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

experiment.trials
└── Trial (index 0)
└── Arm "0_0"
├── arm.parameters = {"Hs": 4.2, "Tp": 8.7} → X
└── trial.run_metadata["simulation_result"]
→ LocalMetadataMetric reads it
→ df row: arm_name="0_0", metric_name="loc"
mean=12.3, sem=0.4 # mean → Y, sem² → Yvar

Is not displayed well. Maybe you can find a better way of describing this. As a one liner it is hard to understand.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more explanations what you are doing now and why. For example "extract_training_tensors" comes a bit out of thin air. It's great that you have added a docstring but in a notebook I would expect a short explanation before the code.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split up your code segments more. E.g. the segment of run_loo is very long. If you split it up into smaller chuncks, e.g. one per function/ class, and add some high level explanation then it would be much easier to understand what is going on.

@am-kaiser am-kaiser requested a review from swinter1 April 1, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants