Skip to content

Upgraded analyst lib, use new libtapir interface#10

Merged
zluudg merged 1 commit into
mainfrom
leon/dev
Apr 16, 2026
Merged

Upgraded analyst lib, use new libtapir interface#10
zluudg merged 1 commit into
mainfrom
leon/dev

Conversation

@zluudg
Copy link
Copy Markdown
Collaborator

@zluudg zluudg commented Apr 16, 2026

Summary by CodeRabbit

  • Chores
    • Updated Go module dependencies to their latest versions.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

📝 Walkthrough

Walkthrough

The changes remove the libtapir handle dependency from application configuration and initialization, switching from instance-based to package-level function calls for libtapir functionality. Dependencies are also updated in go.mod.

Changes

Cohort / File(s) Summary
Libtapir Handle Removal
cmd/observation-encoder/main.go, internal/app/app.go
Removed libtapir configuration from structs, eliminated handle instantiation and storage, and refactored GenerateObservationMsg calls to use the package-level function instead of instance methods.
Dependency Updates
go.mod
Bumped tapir-analyse-lib, nats.go, and several indirect dependencies to newer versions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 A handle once held close now flies free,
Package-level calls dance with glee!
Simpler configs, cleaner ways,
Dependencies updated for brighter days!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Upgraded analyst lib, use new libtapir interface' accurately reflects the main changes: upgrading the tapir-analyse-lib dependency and refactoring to use the package-level libtapir function instead of a handle instance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch leon/dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@cmd/observation-encoder/main.go`:
- Around line 27-31: The removed [libtapir] block breaks startup when existing
config.toml still contains that table because
confDecoder.DisallowUnknownFields() will reject unknown fields; restore a
compatibility sink by adding a deprecated ignored field to the conf struct
(e.g., add a field named Libtapir of a non-validating type such as
toml.Primitive or map[string]interface{} with struct tag `toml:"libtapir"`) so
the decoder will accept and ignore that block while keeping
confDecoder.DisallowUnknownFields() in place.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8aa6e5c9-ba26-4fcf-8df2-a5a318ed20d0

📥 Commits

Reviewing files that changed from the base of the PR and between 2ece38b and 4b037de.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • cmd/observation-encoder/main.go
  • go.mod
  • internal/app/app.go

Comment thread cmd/observation-encoder/main.go
@zluudg zluudg merged commit cc26dac into main Apr 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant