refactor: convert FormStatus from class to functional component#6935
Merged
tujoworker merged 11 commits intov11from Apr 5, 2026
Merged
refactor: convert FormStatus from class to functional component#6935tujoworker merged 11 commits intov11from
tujoworker merged 11 commits intov11from
Conversation
|
Branch Preview URL (stable): Deployment URL (unique): |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
langz
force-pushed
the
refactor/form-status-to-functional
branch
7 times, most recently
from
4777f67 to
66fe7bb
Compare
langz
force-pushed
the
refactor/form-status-to-functional
branch
5 times, most recently
from
343f374 to
18e14e1
Compare
tujoworker
approved these changes
Mar 24, 2026
Member
tujoworker
left a comment
tujoworker
left a comment
There was a problem hiding this comment.
This PR needs manual testing for the width handling. From my experience, width tests with JSDom is not always the same as in a browser.
I was not able to test it manually at the moment.
Contributor
Author
|
I'll rebase this with latest v11 to make sure that it's working as expected with that before merging. |
langz
force-pushed
the
refactor/form-status-to-functional
branch
2 times, most recently
from
c7da72a to
d4448ee
Compare
The useMemo for id had an empty dependency array, causing the FormStatus id to never update when the parent component changed the id prop. This fixes the FieldBlock test that verifies aria-describedby uses forId when provided.
…eEffect in FormStatus
The fillCache callback had ownProps (a new object each render) in its dependency array, causing unnecessary re-creation every render. Since fillCache is only called from effects (useMountEffect/useUpdateEffect), reading from a ref is safe — it will always have the current value by the time effects run.
- Replace `restOfProps as any` with proper destructuring from typed rest
- Replace `{...params as any}` with typed Record<string, unknown> for params
- Replace `context as Record<string, any>` with proper context property access
- Import FormElementProps for typed globalStatus context access
tujoworker
force-pushed
the
refactor/form-status-to-functional
branch
from
d4448ee to
d5505a6
Compare
Member
|
Did test things manually. Worked as expected/before. |
1 similar comment
Member
|
Did test things manually. Worked as expected/before. |
tujoworker
added a commit
that referenced
this pull request
Apr 5, 2026
Co-authored-by: Tobias Høegh <tobias@tujo.no>
tujoworker
added a commit
that referenced
this pull request
Apr 5, 2026
Co-authored-by: Tobias Høegh <tobias@tujo.no>
tujoworker
added a commit
that referenced
this pull request
Apr 5, 2026
Co-authored-by: Tobias Høegh <tobias@tujo.no>
tujoworker
added a commit
that referenced
this pull request
Apr 6, 2026
Co-authored-by: Tobias Høegh <tobias@tujo.no>
tujoworker
added a commit
that referenced
this pull request
Apr 6, 2026
Co-authored-by: Tobias Høegh <tobias@tujo.no>
tujoworker
added a commit
that referenced
this pull request
Apr 6, 2026
Co-authored-by: Tobias Høegh <tobias@tujo.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.