You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@dmnfarrell there are three issues that I eventually noticed:
in dialogs.py, there is the following code:
if mask is None:
mask = df.index == df.index
Looks strange... I believe x==x always returns True, except if x is None or np.nan. If that is your intention, I would suggest to do it in more gracious way: mask = mask or np.isnan(df.index)
2. In several places I see the following: webbrowser.open(link, autoraise=1)
Tools show a warning here, because autoraise parameter is declared to be BOOL.
Did you mean to use "new" parameter?
3. In core.py:
cmap = d.results[0]
alpha = float(d.results[1])
df = self.model.df
for col in cols:
colname = df.columns[col]
x = df[colname]
clrs = self.values_to_colors(x, cmap, alpha)
clrs = pd.Series(clrs, index=df.index)
rc = self.rowcolors
rc[colname] = clrs
Why is the casting to float? The respective parameter of values_to_colors() is declared to be int and d.results[1] is declared as int too.
Is the casting redundant or the 3rd parameter of values_to_colors() should be changed to float?
def popupFocusOut(event):
popupmenu.unpost()
if outside is None:
# if outside table, just show general items
row = self.get_row_clicked(event)
col = self.get_col_clicked(event)
coltype = self.model.getColumnType(col)
Does popupFocusOut(): really contain only one line, or there is a broken indentation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the most trivial changes: spaces, removal of trailing semicolons, using
is Noneinstead of==Noneetc.