This repository was archived by the owner on Mar 25, 2020. It is now read-only.
Added fixes to problems that occur on python3#43
Open
botev wants to merge 2 commits intodmlc:masterfrom
Open
Conversation
|
I just ran into this issue as well. It'd be great to have it merged. |
Member
|
@keunhong Could you help verify this? Thank you. I'm going to change the backend to tensorflow/tensorboard these days first, and change the project name to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following errors happened when initially running tensorboard in python3:
StringIOwas giving the following error:TypeError: string argument expected, got 'bytes'
Applied the fix from here: https://stackoverflow.com/questions/6479100/python-stringio-replacement-that-works-with-bytes-instead-of-strings , which suggests that BytesIO will work on both python2 and python3.
https://stackoverflow.com/questions/16720682/pil-cannot-write-mode-f-to-jpeg
Thus I added a line to convert it to RGB.
This made the colorspace redundant as it already converts it to 3 channel even in the case of 2 channels.
uint8between 0 and 255.