Fix bug in assign_op.h, Use not existed variables#101
Open
chunyang-wen wants to merge 2 commits intodmlc:masterfrom
Open
Fix bug in assign_op.h, Use not existed variables#101chunyang-wen wants to merge 2 commits intodmlc:masterfrom
chunyang-wen wants to merge 2 commits intodmlc:masterfrom
Conversation
Author
|
It seems that Travis break(caused by van.cc) has nothing to do with this PR. |
eric-haibin-lin
added a commit
to eric-haibin-lin/ps-lite
that referenced
this pull request
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code in assign_op.h uses wrong variables. assign_op.h is included in parallel_kv_match.h. But it seems that parallel_kv_match.h is not used.