Open
Conversation
make its optimizer configured same as Python's fix #369
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
=======================================
Coverage 69.74% 69.74%
=======================================
Files 25 25
Lines 1963 1963
=======================================
Hits 1369 1369
Misses 594 594Continue to review full report at Codecov.
|
rickhg12hs
reviewed
Dec 12, 2017
examples/mnist/lenet.jl
Outdated
| mx.fit(model, optimizer, train_provider, n_epoch=20, eval_data=eval_provider) | ||
| mx.fit(model, optimizer, train_provider, | ||
| n_epoch=20, | ||
| eval_data=eval_provider |
There was a problem hiding this comment.
This line needs a comma , at the end, yes?
e3dbeae to
5e27ab1
Compare
Member
Author
|
Do you have any GPU to try it out? |
|
I have no GPU, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make its optimizer configured same as Python's
fix #369
@rickhg12hs Could you checkout it?