This repository was archived by the owner on Jun 27, 2024. It is now read-only.
Feature/add schema selection #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlospt
reviewed
Feb 9, 2021
pgdatadiff/pgdatadiff.py
Outdated
| def __init__(self, firstdb, seconddb, schema, chunk_size=10000, count_only=False, exclude_tables=""): | ||
| firstsession, firstengine = make_session(firstdb) | ||
| secondsession, secondengine = make_session(seconddb) | ||
| secondsession, secondengine = make_session(seconddb,) |
| class DBDiff(object): | ||
|
|
||
| def __init__(self, firstdb, seconddb, chunk_size=10000, count_only=False): | ||
| def __init__(self, firstdb, seconddb, schema, chunk_size=10000, count_only=False, exclude_tables=""): |
There was a problem hiding this comment.
@andrikoz Shall we follow the exclude_tables pattern here instead?
schema="public"
pgdatadiff/main.py
Outdated
| __doc__, version=pkg_resources.require("pgdatadiff")[0].version) | ||
| first_db_connection_string=arguments['--firstdb'] | ||
| second_db_connection_string=arguments['--seconddb'] | ||
| arguments['--schema'] = 'public' if not arguments['--schema'] else True |
There was a problem hiding this comment.
@andrikoz based on default values suggestion below, we can just remove it!
andrikoz
force-pushed
the
feature/add-schema-selection
branch
from
e74141e to
09cb60f
Compare
andrikoz
force-pushed
the
feature/add-schema-selection
branch
from
09cb60f to
43fbf16
Compare
|
This is assuming the same schema for both dbs though right? What about 2 different schemas which is what this issue is asking. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.