🎨 Palette: Improve compose FAB long-press accessibility discoverability by Copilot · Pull Request #119 · dlukt/techidon

Copilot · 2026-03-29T15:42:02Z

Review new actionable PR comment and confirm required fix scope
Investigate CI/build status via GitHub Actions runs and logs
Inspect current FAB long-click wiring in both affected fragments
Fix listener regression so long-press works again after account-count changes
Run targeted local validation commands
Run automated code review and security scan
Reply to the new PR comment with commit hash and screenshot

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Agent-Logs-Url: https://github.com/dlukt/techidon/sessions/9e5a77c2-6b44-4cf9-a830-c338e7e8653a Co-authored-by: dlukt <201112286+dlukt@users.noreply.github.com>

Copilot

Pull request overview

Adds tooltip affordance to the icon-only “new post” compose FAB to improve discoverability and align with existing UI patterns that use android:tooltipText.

Changes:

Added android:tooltipText="@string/new_post" to the compose FAB in timeline and shared FAB layouts.
Minor formatting/indentation normalization in fragment_timeline.xml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
mastodon/src/main/res/layout/fragment_timeline.xml	Adds tooltip text to the timeline FAB (and normalizes closing tag indentation).
mastodon/src/main/res/layout/compose_fab.xml	Adds tooltip text to the reusable compose FAB layout.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-29T15:54:45Z

mastodon/src/main/res/layout/fragment_timeline.xml

 			android:contentDescription="@string/new_post"
+			android:tooltipText="@string/new_post"
 			android:src="@drawable/ic_fluent_compose_24_filled"/>


android:tooltipText is unlikely to appear on long-press here because the FAB has an OnLongClickListener (used for account picking when multiple accounts) which typically suppresses the tooltip when the long-click is consumed. If the goal is long-press discoverability, consider adjusting the FAB long-click handling (or showing the affordance via another mechanism) so the tooltip can still be displayed; otherwise this tooltip will mainly help hover/mouse use cases.

Copilot · 2026-03-29T15:54:45Z

mastodon/src/main/res/layout/compose_fab.xml

    android:stateListAnimator="@animator/fab_shadow"
    android:contentDescription="@string/new_post"
+    android:tooltipText="@string/new_post"
    android:src="@drawable/ic_fluent_compose_24_filled" />


Same as in fragment_timeline.xml: this FAB is wired up with an OnLongClickListener in code (account picker when multiple accounts), which commonly prevents tooltips from showing on long-press. If the intent is to improve long-press discoverability, the long-click/tooltip interaction needs to be handled explicitly; otherwise this is primarily a hover tooltip.

dlukt · 2026-03-29T15:56:19Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/dlukt/techidon/sessions/926c874f-1358-4775-b24e-410211b4e3f4 Co-authored-by: dlukt <201112286+dlukt@users.noreply.github.com>

Copilot · 2026-03-29T16:04:58Z

@copilot apply changes based on the comments in this thread

Applied in commit 778998b (with the functional change in 6d382a8): I removed the FAB tooltip approach and instead added explicit accessibility long-click action labels on the compose FAB where long-press is consumed by account picker. It now exposes “Add or switch accounts” via ACTION_LONG_CLICK when multiple accounts exist, and clears that action label otherwise. Screenshot: https://github.com/user-attachments/assets/8285617d-2cee-4b20-a636-8487ba5bc7b0

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-29T17:20:36Z

mastodon/src/main/java/de/icod/techidon/fragments/HomeTabFragment.java

+		if (AccountSessionManager.getInstance().getLoggedInAccounts().size() > 1) {
+			ViewCompat.replaceAccessibilityAction(fab, AccessibilityNodeInfoCompat.AccessibilityActionCompat.ACTION_LONG_CLICK, getString(R.string.manage_accounts), null);
+		} else {
+			ViewCompat.replaceAccessibilityAction(fab, AccessibilityNodeInfoCompat.AccessibilityActionCompat.ACTION_LONG_CLICK, null, null);
+		}


The long-click accessibility label is set only once during view creation. If the user adds/removes accounts (changing getLoggedInAccounts().size()) while this fragment stays alive (e.g., via account management screens and returning), TalkBack can advertise an out-of-date long-press action label that no longer matches what long-press does. Consider extracting this into an updateFabLongClickAccessibilityAction() method and calling it from a lifecycle callback that runs on return/visibility changes (e.g., onResume()/onShown()), so the label always reflects the current account count.

Copilot · 2026-03-29T17:20:37Z

mastodon/src/main/java/de/icod/techidon/fragments/BaseStatusListFragment.java

+			if (AccountSessionManager.getInstance().getLoggedInAccounts().size() > 1) {
+				ViewCompat.replaceAccessibilityAction(fab, AccessibilityNodeInfoCompat.AccessibilityActionCompat.ACTION_LONG_CLICK, getString(R.string.manage_accounts), null);
+			} else {
+				ViewCompat.replaceAccessibilityAction(fab, AccessibilityNodeInfoCompat.AccessibilityActionCompat.ACTION_LONG_CLICK, null, null);
+			}


This accessibility action label is computed only at onViewCreated time. If the logged-in account count changes while the fragment remains in the back stack, the ACTION_LONG_CLICK label can become stale (e.g., still announcing “manage accounts” after the user logs out to a single account, even though long-press won’t open the picker). Consider centralizing this logic (e.g., updateFabLongClickAccessibilityAction()) and invoking it from onResume()/onShown() as well, so assistive tech always gets the correct long-press description.

dlukt · 2026-03-29T17:21:09Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/dlukt/techidon/sessions/1b4b5413-4505-4b31-bcb1-34ac8ed53058 Co-authored-by: dlukt <201112286+dlukt@users.noreply.github.com>

Copilot · 2026-03-29T17:29:34Z

@copilot apply changes based on the comments in this thread

Applied in 89e27bb (with the lifecycle refresh extraction in acf9ad5). The compose FAB long-click accessibility action is now centralized in updateFabLongClickAccessibilityAction() and refreshed both during setup and when the fragment is shown again, so account-count changes don’t leave stale TalkBack labels. Screenshot: https://github.com/user-attachments/assets/7a07f610-b376-4dcf-b3cf-e8d3d4224410

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mastodon/src/main/java/de/icod/techidon/fragments/HomeTabFragment.java

mastodon/src/main/java/de/icod/techidon/fragments/BaseStatusListFragment.java

…stFragment.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ent.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mastodon/src/main/java/de/icod/techidon/fragments/HomeTabFragment.java

Copilot · 2026-03-30T08:58:25Z

mastodon/src/main/java/de/icod/techidon/fragments/BaseStatusListFragment.java

+		boolean multipleAccounts = AccountSessionManager.getInstance().getLoggedInAccounts().size() > 1;
+
+		// Only expose a long-click action (including to accessibility services)
+		// when there are multiple accounts to manage.
+		fab.setLongClickable(multipleAccounts);
+		if (!multipleAccounts) {
+			fab.setOnLongClickListener(null);
+		}


updateFabLongClickAccessibilityAction() nulls the FAB’s OnLongClickListener when only one account exists, but doesn’t restore it when multipleAccounts becomes true later (e.g., after adding a second account and returning to the fragment). This leaves long-press permanently broken until the view is recreated. Fix by keeping the listener attached and relying on setLongClickable(false), or reattaching fab.setOnLongClickListener(this::onFabLongClick) when multipleAccounts is true.

@copilot apply changes based on this feedback

Applied in 688a383. I removed the fab.setOnLongClickListener(null) branch so the long-click listener remains attached, and we rely on fab.setLongClickable(multipleAccounts) plus accessibility-action updates to control exposure. This restores long-press behavior when account count returns to multiple accounts. Screenshot: https://github.com/user-attachments/assets/6ebac5ec-7eee-4818-9052-efcab138219d

…ent.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dlukt/techidon/sessions/2ed82beb-b54c-4425-86d0-1ca04da739dd Co-authored-by: dlukt <201112286+dlukt@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mastodon/src/main/java/de/icod/techidon/fragments/BaseStatusListFragment.java

mastodon/src/main/java/de/icod/techidon/fragments/HomeTabFragment.java

Copilot · 2026-03-30T23:30:44Z

mastodon/src/main/java/de/icod/techidon/fragments/BaseStatusListFragment.java

+	private void updateFabLongClickAccessibilityAction() {
+		if (fab == null)
+			return;
+
+		boolean multipleAccounts = AccountSessionManager.getInstance().getLoggedInAccounts().size() > 1;
+


updateFabLongClickAccessibilityAction() duplicates the same logic now present in HomeTabFragment (and partially in other views). To reduce the chance of future drift (e.g., label/resource changes), consider extracting this into a shared helper (e.g., in UiUtils) that takes the target view and label resource.

Copilot · 2026-03-30T23:30:44Z

mastodon/src/main/java/de/icod/techidon/fragments/HomeTabFragment.java

+		fab.setLongClickable(multipleAccounts);
+
+		if (multipleAccounts) {
+			ViewCompat.replaceAccessibilityAction(
+					fab,
+					AccessibilityNodeInfoCompat.AccessibilityActionCompat.ACTION_LONG_CLICK,
+					getString(R.string.manage_accounts),
+					null
+			);
+		} else {
+			ViewCompat.replaceAccessibilityAction(
+					fab,
+					AccessibilityNodeInfoCompat.AccessibilityActionCompat.ACTION_LONG_CLICK,
+					null,
+					null
+			);
+		}


updateFabLongClickAccessibilityAction() mirrors the same implementation added in BaseStatusListFragment. Consider extracting a shared helper (e.g., UiUtils.updateLongClickActionLabel(view, enabled, @StringRes label)) to avoid duplicated accessibility logic across fragments.

Suggested change

fab.setLongClickable(multipleAccounts);

if (multipleAccounts) {

ViewCompat.replaceAccessibilityAction(

fab,

AccessibilityNodeInfoCompat.AccessibilityActionCompat.ACTION_LONG_CLICK,

getString(R.string.manage_accounts),

null

);

} else {

ViewCompat.replaceAccessibilityAction(

fab,

AccessibilityNodeInfoCompat.AccessibilityActionCompat.ACTION_LONG_CLICK,

null,

null

);

}

UiUtils.updateLongClickActionLabel(fab, multipleAccounts, R.string.manage_accounts);

…stFragment.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ent.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

454bcb1

Copilot AI assigned Copilot and dlukt Mar 29, 2026

Copilot started work on behalf of dlukt March 29, 2026 15:42 View session

feat: add tooltip text for timeline compose FAB

55ac829

Agent-Logs-Url: https://github.com/dlukt/techidon/sessions/9e5a77c2-6b44-4cf9-a830-c338e7e8653a Co-authored-by: dlukt <201112286+dlukt@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Enhance button accessibility with ARIA labels~~ 🎨 Palette: Add tooltip affordance to compose FAB Mar 29, 2026

Copilot finished work on behalf of dlukt March 29, 2026 15:47

Copilot AI requested a review from dlukt March 29, 2026 15:47

dlukt marked this pull request as ready for review March 29, 2026 15:51

Copilot AI review requested due to automatic review settings March 29, 2026 15:51

Copilot started reviewing on behalf of dlukt March 29, 2026 15:51 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

Copilot started work on behalf of dlukt March 29, 2026 15:56 View session

Copilot AI and others added 3 commits March 29, 2026 15:59

chore: plan follow-up for fab accessibility feedback

036a68c

Agent-Logs-Url: https://github.com/dlukt/techidon/sessions/926c874f-1358-4775-b24e-410211b4e3f4 Co-authored-by: dlukt <201112286+dlukt@users.noreply.github.com>

fix: label compose fab long-click accessibility action

6d382a8

Agent-Logs-Url: https://github.com/dlukt/techidon/sessions/926c874f-1358-4775-b24e-410211b4e3f4 Co-authored-by: dlukt <201112286+dlukt@users.noreply.github.com>

style: format fab accessibility action conditionals

778998b

Agent-Logs-Url: https://github.com/dlukt/techidon/sessions/926c874f-1358-4775-b24e-410211b4e3f4 Co-authored-by: dlukt <201112286+dlukt@users.noreply.github.com>

Copilot AI changed the title ~~🎨 Palette: Add tooltip affordance to compose FAB~~ 🎨 Palette: Improve compose FAB long-press accessibility discoverability Mar 29, 2026

Copilot finished work on behalf of dlukt March 29, 2026 16:06

dlukt requested a review from Copilot March 29, 2026 17:17

Copilot started reviewing on behalf of dlukt March 29, 2026 17:17 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

Copilot started work on behalf of dlukt March 29, 2026 17:21 View session

Copilot AI and others added 2 commits March 29, 2026 17:26

fix: refresh fab accessibility action label on shown

acf9ad5

Agent-Logs-Url: https://github.com/dlukt/techidon/sessions/1b4b5413-4505-4b31-bcb1-34ac8ed53058 Co-authored-by: dlukt <201112286+dlukt@users.noreply.github.com>

fix: guard fab accessibility refresh on shown

89e27bb

Agent-Logs-Url: https://github.com/dlukt/techidon/sessions/1b4b5413-4505-4b31-bcb1-34ac8ed53058 Co-authored-by: dlukt <201112286+dlukt@users.noreply.github.com>

Copilot finished work on behalf of dlukt March 29, 2026 17:30

dlukt requested a review from Copilot March 30, 2026 00:05

Copilot started reviewing on behalf of dlukt March 30, 2026 00:05 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

mastodon/src/main/java/de/icod/techidon/fragments/HomeTabFragment.java Outdated Show resolved Hide resolved

mastodon/src/main/java/de/icod/techidon/fragments/BaseStatusListFragment.java Outdated Show resolved Hide resolved

dlukt and others added 2 commits March 30, 2026 10:55

Update mastodon/src/main/java/de/icod/techidon/fragments/BaseStatusLi…

3ba705f

…stFragment.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update mastodon/src/main/java/de/icod/techidon/fragments/HomeTabFragm…

0efef58

…ent.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

dlukt requested a review from Copilot March 30, 2026 08:55

Copilot started reviewing on behalf of dlukt March 30, 2026 08:56 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Update mastodon/src/main/java/de/icod/techidon/fragments/HomeTabFragm…

b354662

…ent.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of dlukt March 30, 2026 21:58 View session

fix: keep fab long-click listener attached

688a383

Agent-Logs-Url: https://github.com/dlukt/techidon/sessions/2ed82beb-b54c-4425-86d0-1ca04da739dd Co-authored-by: dlukt <201112286+dlukt@users.noreply.github.com>

Copilot finished work on behalf of dlukt March 30, 2026 22:06

dlukt requested a review from Copilot March 30, 2026 23:27

Copilot started reviewing on behalf of dlukt March 30, 2026 23:28 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

dlukt and others added 2 commits March 31, 2026 01:36

Update mastodon/src/main/java/de/icod/techidon/fragments/BaseStatusLi…

7ef238d

…stFragment.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update mastodon/src/main/java/de/icod/techidon/fragments/HomeTabFragm…

8e15173

…ent.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

dlukt closed this Mar 30, 2026

Uh oh!

Conversation

Copilot AI commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

dlukt commented Mar 29, 2026

Uh oh!

Copilot AI commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

dlukt commented Mar 29, 2026

Uh oh!

Copilot AI commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

dlukt Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 29, 2026 •

edited

Loading