Skip to content

MVC to fix edge case for BoxModel and DeckofCards #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdatko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MVC to fix edge case for BoxModel and DeckofCards #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions symbulate/probability_space.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ class BoxModel(ProbabilitySpace):
sorted before returning or not.
"""

def __init__(self, box, size=None, replace=True, probs=None, order_matters=True):
def __init__(self, box, size=1, replace=True, probs=None, order_matters=True):
if isinstance(box, list):
self.box = box
self.probs = probs
Expand All @@ -142,7 +142,7 @@ def __init__(self, box, size=None, replace=True, probs=None, order_matters=True)
raise Exception(
"Box must be specified either as a list or a dict."
)
self.size = None if size == 1 else size
self.size = size
self.replace = replace
self.order_matters = order_matters
self.output_type = Vector
Expand All @@ -155,6 +155,7 @@ def __init__(self, box, size=None, replace=True, probs=None, order_matters=True)
"Cannot draw more tickets (without replacement) "
"than there are tickets in the box."
)
self.size = None if size == 1 else size

def draw(self):
"""
Expand Down