Model select 2 pulltest#4
Open
dlktdr wants to merge 93 commits into
Open
Conversation
…o model_select_2
2. capitalized the first letter of the labels 3. added a new button which is better than having it in the context menu 4. fixed a defect when rendering an invalid model. I made the text render in the center fo the bitmap 5. fixed focus handling of the model selector 6. added back selection processing in the update of the ModelSelector
2. removed the artificial label "unlabeled". 3. fixed the code to add an "unlabeled" entry to the listbox, and fixed the modelselector to call getUnlabeledModels() appropriately 4. changed the code in model setup to use a menu with checkboxes to set the labels. Things to do: 1. create new label 2. easily add labels to models from the model selector 3. fix new model so it doesnt create invalid models. Also add model to current label so it is visibile. I guess if you press new, it should automatically add the right label.
2. on long press of the ModelButton we bring up a different menu to choose the labels a model is part of. There is still work to do here, and i am not sure this is a good UI. But it works for now. 3. Changed title paint of ModelButton: opacity of 5 was not working for me. I made it the default for now. 4. fixed focus handling
2. fixed sliding and longpress. Touch is such a pain 3. add soft refresh after changing the labels of a model. It uses checkEvents to update after the menu is dismissed. 4. added title to popup menus as the focus box is not drawn when the menu is displayed so it is hard to know which model you are working on. 5. removed some long term dead code that we might want back? 6. set the active label to the the first label of the currently selected model. This way your selected model is always displayed when you first start the model selector.
remove old comment and redundant nulling on initialization.
Don't hide some important trace messages behind DEBUG_LABELS Remove unnecessary scan of the modelslist. Fix strcpy on model bitmap, use strn
…r sharing with Cliff
2. dont display menu for "Unlabled"
2. rewrote ButtonHolder() to make it more generic. With a little work this can be used in other screens. 3. fixed new label dialog size on nv14
2. add callback hander to plug in back end logic 3. clean up old add model functionality that is no longer being used. 4. add calls to back end logic to handle sorting. 5. fixed backend sortModelsBy(). You can compare two character arrays using < > you need to use strcmp. Sorting now seems to work even at the UI. We still have to figure out sorting and not having the selected model on the screen. You should always be able to find the selected model easily. There is no good way to do that yet. We also need label sorting. I am going to work on that tomorrow
…elayed writes before rename.
2. Edit labels as a sub menu item 3. Add label button moved into long press on labels 4. Wider Labels Selector 5. Translations 6. Hide unlabled if empty 7. Make ListBox Multiselectable
Don't include YAML processing on DEBUG_LABELS
** Still needs to update the static text on close of the number
Adds the label title to the menu so you know what you have selected
2. When deselecting in multiselect focus was not update 3. On long press in multiselect only update focus
dlktdr
force-pushed
the
model_select_2_pulltest
branch
from
b4eda08 to
81c6e65
Compare
dlktdr
pushed a commit
that referenced
this pull request
May 30, 2023
added a static method for number formatting as expected by drawText
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note that pull requests are NOT an appropriate way to ask questions or for support.
For feature request or bug reports, please use the Issues tab.
For support, please use the Discussion tab or join us on Discord.
Fixes #
Summary of changes: