Immediate completion of none channel#1170
Merged
JackLewis-digirati merged 8 commits intodevelopfrom Apr 14, 2026
Merged
Conversation
JackLewis-digirati
force-pushed
the
feature/immediateNoneChannelReturn
branch
from
3d4b769 to
f5b228c
Compare
donaldgray
requested changes
Apr 13, 2026
JackLewis-digirati
changed the title
JackLewis-digirati
changed the title
- Move updating delivery channel details into CreateOrUpdateImage - Create a repository class to work with ImageStorage - Make sure image storage record updated - Additional tests to cover
donaldgray
approved these changes
Apr 14, 2026
- Add additional comments - Remove commented code
donaldgray
added a commit
that referenced
this pull request
Apr 14, 2026
Rebased as PR #1170 had been merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1154
What does this change?
This PR modifies the
Nonedelivery channel to complete without needing to be ingested - this PR will also raise acompletedbatch notification immediately if required