Skip to content

Allow POSTing of multiple Adjuncts in one request for creation#1167

Merged
p-kaczynski merged 7 commits intodevelopfrom
feature/1110/register_mult_adjunct
Apr 8, 2026
Merged

Allow POSTing of multiple Adjuncts in one request for creation#1167
p-kaczynski merged 7 commits intodevelopfrom
feature/1110/register_mult_adjunct

Conversation

@p-kaczynski
Copy link
Copy Markdown
Contributor

@p-kaczynski p-kaczynski commented Mar 31, 2026

What does this change?

Impl #1110

  • POST to /adjuncts now can take:
    • Adjunct object (as before)
    • JSON Array of Adjunct objects
    • HydraCollection object with members being JSON Array of Adjunct objects
  • CreateOrUpdateAdjunct now assumes working on n Adjuncts by default
  • Returns Adjunct, if one Adjunct was posted, or a HydraCollection of Adjuncts if multiple (TBD: currently under discussion. I believe it to be more in-line with the polymorphic input handling, and it doesn't break existing tests.)
  • Tries to fail-early and saves adjuncts to the DB in a single transaction
  • Returns success only if all actions (db save, ingest notify, modification notify) succeed, otherwise returns descriptive error

--

Commits:

  • Initial work on multiple adjunct posting
  • Rework polymorphic ItemArrayOrHydraCollectionConverter to correctly handle various input cases
  • Add positive tests for multiple adjuncts posting
  • Cleanup and fixes for mult adjuncts
  • Add negative tests for multiple adjuncts posting

@p-kaczynski p-kaczynski requested a review from a team as a code owner March 31, 2026 12:31
@JackLewis-digirati
Copy link
Copy Markdown
Collaborator

Additionally, the name of the PR could be more helpful as it goes into the commit history + the description of the PR is missing the Resolves to link the issue

@p-kaczynski p-kaczynski changed the title Feature/1110/register mult adjunct Allow POSTing of multiple Adjuncts in one request for creation Apr 1, 2026
@p-kaczynski p-kaczynski linked an issue Apr 1, 2026 that may be closed by this pull request
4 tasks
@p-kaczynski p-kaczynski force-pushed the feature/1110/register_mult_adjunct branch from 4e54b2a to 1fa8476 Compare April 1, 2026 14:34
@p-kaczynski p-kaczynski merged commit 30eab1b into develop Apr 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support registering multiple adjuncts in single payload

3 participants