Skip to content

Rename PackageName.main to .base to making naming consistent#3084

Open
s-ludwig wants to merge 4 commits intomasterfrom
base_package_consistency
Open

Rename PackageName.main to .base to making naming consistent#3084
s-ludwig wants to merge 4 commits intomasterfrom
base_package_consistency

Conversation

@s-ludwig
Copy link
Copy Markdown
Member

This is and has always been referred to "base package name" throughout the code base and should be named like this here, too, to avoid confusion.

Also reduces the amount of explicit attribute annotations a bit.

@s-ludwig s-ludwig requested a review from Geod24 December 27, 2025 08:12
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 27, 2025

✅ PR OK, no changes in deprecations or warnings

Total deprecations: 0

Total warnings: 0

Build statistics:

 statistics (-before, +after)
 executable size=5710288 bin/dub
-rough build time=67s
+rough build time=65s
Full build output
DUB version 1.41.0, built on Mar  1 2026
LDC - the LLVM D compiler (1.42.0):
  based on DMD v2.112.1 and LLVM 21.1.8
  built with LDC - the LLVM D compiler (1.42.0)
  Default target: x86_64-unknown-linux-gnu
  Host CPU: znver3
  https://dlang.org - https://wiki.dlang.org/LDC


  Registered Targets:
    aarch64     - AArch64 (little endian)
    aarch64_32  - AArch64 (little endian ILP32)
    aarch64_be  - AArch64 (big endian)
    amdgcn      - AMD GCN GPUs
    arm         - ARM
    arm64       - ARM64 (little endian)
    arm64_32    - ARM64 (little endian ILP32)
    armeb       - ARM (big endian)
    avr         - Atmel AVR Microcontroller
    bpf         - BPF (host endian)
    bpfeb       - BPF (big endian)
    bpfel       - BPF (little endian)
    hexagon     - Hexagon
    lanai       - Lanai
    loongarch32 - 32-bit LoongArch
    loongarch64 - 64-bit LoongArch
    mips        - MIPS (32-bit big endian)
    mips64      - MIPS (64-bit big endian)
    mips64el    - MIPS (64-bit little endian)
    mipsel      - MIPS (32-bit little endian)
    msp430      - MSP430 [experimental]
    nvptx       - NVIDIA PTX 32-bit
    nvptx64     - NVIDIA PTX 64-bit
    ppc32       - PowerPC 32
    ppc32le     - PowerPC 32 LE
    ppc64       - PowerPC 64
    ppc64le     - PowerPC 64 LE
    r600        - AMD GPUs HD2XXX-HD6XXX
    riscv32     - 32-bit RISC-V
    riscv64     - 64-bit RISC-V
    sparc       - Sparc
    sparcel     - Sparc LE
    sparcv9     - Sparc V9
    spirv       - SPIR-V Logical
    spirv32     - SPIR-V 32-bit
    spirv64     - SPIR-V 64-bit
    systemz     - SystemZ
    thumb       - Thumb
    thumbeb     - Thumb (big endian)
    ve          - VE
    wasm32      - WebAssembly 32-bit
    wasm64      - WebAssembly 64-bit
    x86         - 32-bit X86: Pentium-Pro and above
    x86-64      - 64-bit X86: EM64T and AMD64
    xcore       - XCore
    xtensa      - Xtensa 32
   Upgrading project in /home/runner/work/dub/dub/
    Starting Performing "release" build using /opt/hostedtoolcache/dc/ldc2-1.42.0/x64/ldc2-1.42.0-linux-x86_64/bin/ldc2 for x86_64.
    Building dub 1.42.0-beta.1+commit.7.gc01d62e5: building configuration [application]
     Linking dub
STAT:statistics (-before, +after)
STAT:executable size=5710288 bin/dub
STAT:rough build time=65s

@s-ludwig s-ludwig force-pushed the base_package_consistency branch from 792ee2a to 58c8cce Compare January 13, 2026 11:23
@the-horo
Copy link
Copy Markdown
Contributor

Some tests failure because setup-dlang@v2 changed the way DC is set:

[INFO] Running /home/runner/work/dub/dub/test/dc-env.sh...
core.exception.AssertError@app.d(17): Expected 'dmd' but got '/opt/hostedtoolcache/dmd/2.112.0/x64/dmd2/linux/bin64/dmd'
----------------
??:? _d_assert_msg [0x55936729e140]
./app.d:17 _Dmain [0x55936727c875]
Error Program exited with code 1
Error:  /opt/hostedtoolcache/dmd/2.112.0/x64/dmd2/linux/bin64/dub:6 command failed
[ERROR] Script failure.

I guess I should merge dlang-community/setup-dlang#94 since it's been staying there all this time, then you could do:

- name: Install latest DMD
   uses: dlang-community/setup-dlang@v2
   with:
     dc_format: basename

and the test should pass. Alternatively, making it less flasky is also a good idea: https://github.com/the-horo/dub/blob/ba66cf37fd8597fa830805872d169be1a957150d/test/new_tests/issue2012-dc-env/sample/app.d

@s-ludwig s-ludwig force-pushed the base_package_consistency branch 3 times, most recently from db49224 to c45c466 Compare March 27, 2026 16:42
@s-ludwig
Copy link
Copy Markdown
Member Author

Adjusted the test for #2012, (which, by the way, doesn't even look like it tests what it intends to test) and adjusted the CI script/workflow to account for the backslashes that are now in the DC variable. However, there are now other failures.

At this point, I'm giving up. I'll drop the CI related commits.

@s-ludwig s-ludwig force-pushed the base_package_consistency branch from c45c466 to 8053856 Compare March 27, 2026 16:53
@s-ludwig s-ludwig changed the base branch from stable to master March 27, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants