Rename PackageName.main to .base to making naming consistent#3084
Rename PackageName.main to .base to making naming consistent#3084
Conversation
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5710288 bin/dub
-rough build time=67s
+rough build time=65sFull build output |
792ee2a to
58c8cce
Compare
|
Some tests failure because I guess I should merge dlang-community/setup-dlang#94 since it's been staying there all this time, then you could do: - name: Install latest DMD
uses: dlang-community/setup-dlang@v2
with:
dc_format: basenameand the test should pass. Alternatively, making it less flasky is also a good idea: https://github.com/the-horo/dub/blob/ba66cf37fd8597fa830805872d169be1a957150d/test/new_tests/issue2012-dc-env/sample/app.d |
db49224 to
c45c466
Compare
|
Adjusted the test for #2012, (which, by the way, doesn't even look like it tests what it intends to test) and adjusted the CI script/workflow to account for the backslashes that are now in the DC variable. However, there are now other failures. At this point, I'm giving up. I'll drop the CI related commits. |
c45c466 to
8053856
Compare
This is and has always been referred to "base package name" throughout the code base and should be named like this here, too, to avoid confusion.
Also reduces the amount of explicit attribute annotations a bit.