replace nthSucc with Bsuccx#23199
Merged
Merged
Conversation
WalterBright
added
Review:Easy Review
Severity:Refactoring
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#23199" |
thewilsonator
approved these changes
May 30, 2026
Member
Author
|
I hate to do this, but I'm going to revert this. The trouble is I couldn't make the linked list version use the exact same code as the array version, which I was doing to circle in on just where my mistake is. So what I will do is a parallel implementation with this branch, and circle in that way. Ooof. When the compiler crashes in the test suite, having a stack dump would be helpful here. |
WalterBright
added a commit
that referenced
this pull request
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which makes it much more like #23195 in order to narrow down where the problem is in it.