Skip to content

fix Issue 24390 - AssertError@src/dmd/backend/cgxmm.d(1476): Assertion failure#16181

Merged
thewilsonator merged 1 commit into
dlang:masterfrom
ibuclaw:issue24390
Feb 14, 2024
Merged

fix Issue 24390 - AssertError@src/dmd/backend/cgxmm.d(1476): Assertion failure#16181
thewilsonator merged 1 commit into
dlang:masterfrom
ibuclaw:issue24390

Conversation

@ibuclaw
Copy link
Copy Markdown
Member

@ibuclaw ibuclaw commented Feb 12, 2024

This is tickled by #16173, so not actually in any released version of the compiler.

As far as I can tell, the inliner reverts integer promotions by casting from int -> short -> char, the latter type is invalid for vectors. Instead, do cast from int -> short -> byte.

@ibuclaw ibuclaw added the Review:Blocking Other Work review and pulling should be a priority label Feb 12, 2024
@ibuclaw ibuclaw requested a review from WalterBright February 12, 2024 15:33
@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16181"

Copy link
Copy Markdown
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per the bot, please retitle the commit message "Fix bugzilla issue 24390 - ..."

otherwise looks good

@thewilsonator thewilsonator merged commit 9844367 into dlang:master Feb 14, 2024
@ibuclaw ibuclaw deleted the issue24390 branch February 14, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review:Blocking Other Work review and pulling should be a priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants