Skip to content

Fix Issue 23846 - Respect the C standard when it comes to string to f…#15139

Merged
dlang-bot merged 3 commits into
dlang:masterfrom
maxhaton:macosFixFirstAttempt
Apr 28, 2023
Merged

Fix Issue 23846 - Respect the C standard when it comes to string to f…#15139
dlang-bot merged 3 commits into
dlang:masterfrom
maxhaton:macosFixFirstAttempt

Conversation

@maxhaton
Copy link
Copy Markdown
Member

@maxhaton maxhaton commented Apr 27, 2023

…loat ERRNO and return value

@dlang-bot
Copy link
Copy Markdown
Contributor

dlang-bot commented Apr 27, 2023

Thanks for your pull request, @maxhaton!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 23846 major std.math can't compile under macos rosetta

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15139"

@maxhaton
Copy link
Copy Markdown
Member Author

maxhaton commented Apr 27, 2023

Let's find out if it works

kinke
kinke reviewed Apr 27, 2023
View reviewed changes
Comment thread compiler/src/dmd/root/port.d Outdated
@kinke
Copy link
Copy Markdown
Contributor

kinke commented Apr 27, 2023

And do you have a link handy wrt. the standard? As it seems like only Apple chose to break this recently.

dkorpel
dkorpel reviewed Apr 27, 2023
View reviewed changes
Comment thread compiler/src/dmd/root/port.d Outdated
@maxhaton @dkorpel
Update compiler/src/dmd/root/port.d
da02b1c 
Co-authored-by: Dennis <dkorpel@users.noreply.github.com>
@dkorpel
Copy link
Copy Markdown
Contributor

dkorpel commented Apr 28, 2023

CircleCI failure is now because of #15141

@RazvanN7
Copy link
Copy Markdown
Contributor

RazvanN7 commented Apr 28, 2023

@maxhaton please address the reviews and let's get this in! MacOS finally green 🎉

@RazvanN7
Copy link
Copy Markdown
Contributor

RazvanN7 commented Apr 28, 2023

@kinke All ok with this PR?

@dlang-bot dlang-bot merged commit deaf1b8 into dlang:master Apr 28, 2023
@dkorpel
Copy link
Copy Markdown
Contributor

dkorpel commented Apr 28, 2023

Thanks Max!

@PetarKirov PetarKirov mentioned this pull request Feb 13, 2024
Closed
PetarKirov added a commit to PetarKirov/dlang.nix that referenced this pull request Feb 18, 2024
@PetarKirov
fix(pkgs/dmd/{v2.102.2..v2.104.0): Add patch to enable x86_64-darwin …
d14624c 
…compilation

See:
* https://issues.dlang.org/show_bug.cgi?id=23846
* dlang/dmd#15139
PetarKirov added a commit to PetarKirov/dlang.nix that referenced this pull request Feb 18, 2024
@PetarKirov
fix(pkgs/dmd/{v2.102.2..v2.104.0): Add patch to enable x86_64-darwin …
ab36881 
…compilation

See:
* https://issues.dlang.org/show_bug.cgi?id=23846
* dlang/dmd#15139
PetarKirov added a commit to PetarKirov/dlang.nix that referenced this pull request Feb 18, 2024
@PetarKirov
fix(pkgs/dmd/{v2.102.2..v2.104.0): Add patch to enable x86_64-darwin …
50062d0 
…compilation

See:
* https://issues.dlang.org/show_bug.cgi?id=23846
* dlang/dmd#15139
PetarKirov added a commit to PetarKirov/dlang.nix that referenced this pull request Feb 18, 2024
@PetarKirov
fix(pkgs/dmd/{v2.102.2..v2.104.0): Add patch to enable x86_64-darwin …
9a750cd 
…compilation

See:
* https://issues.dlang.org/show_bug.cgi?id=23846
* dlang/dmd#15139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kinke kinke kinke left review comments

@dkorpel dkorpel dkorpel left review comments

@atilaneves atilaneves atilaneves approved these changes

Assignees

No one assigned

Labels

Merge:auto-merge Severity:Bug Fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maxhaton @dlang-bot @kinke @dkorpel @RazvanN7 @atilaneves