Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a pytest CI with different OS'.
os.linesep.This adds https://pre-commit.com/ to the project.
I suggest to also add pre-commit to the CI, https://pre-commit.ci/, so new contributors doesn't have to install pre-commit and run it themself.
I think only maintainers can activate the pre-commit.ci though.
Locally the workflow is:
cdto dcmReader root directorypre-commit run --all-files --hook-stage manualThe config was based on:
Notable things:
--hook-stage manualas it can be slow. There should be a separate workflow for mypy in the CI.