fix(android): prevent summary widget overflow when all groups visible#296
Merged
fix(android): prevent summary widget overflow when all groups visible#296
Conversation
Use defaultWeight() on each group Column so the Row distributes space equally among all visible categories. Reduce font sizes (count 28→24sp, label 13→11sp) and horizontal padding (6→2dp) to fit comfortably even when all 7 groups are shown. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Android TaskSummary Glance widget layout to prevent horizontal overflow when many due-date groups are visible, ensuring all groups remain readable within widget bounds.
Changes:
- Distribute available row width evenly across visible groups using
defaultWeight()on each group column. - Reduce per-group horizontal padding to lower total required width.
- Decrease count/label font sizes to further reduce clipping risk.
Show a summary per file
| File | Description |
|---|---|
| android/app/src/main/java/com/dkhalife/tasks/ui/widget/summary/TaskSummaryWidget.kt | Applies weighted layout + smaller padding/fonts to keep all summary groups within widget bounds. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The TaskSummaryWidget overflows when all due-date groups have tasks. The last groups get clipped -- Later is barely visible and its count is displaced off-screen.
Root Cause
Each group Column in the Row was sized by its intrinsic content width with fixed 6.dp horizontal padding. With 6-7 groups visible, the total intrinsic width exceeded the widget bounds.
Fix