Skip to content

Add warning for default timeout in webpack_loader #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luki009 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add warning for default timeout in webpack_loader #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion webpack_loader/loaders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@
'django_webpack_loader can\'t generate a nonce tag for a bundle, '
'because the passed request doesn\'t contain a "csp_nonce". '
'Chunk name: {chunk_name}')

_LOADER_POSSIBLE_LIMBO = (
'You are using django_webpack_loader with default timeout "None" '
'which can cause request to hang indefinitely. '
'Validate status of webpack-stats.json file if you experience infinite loading.'
)

@lru_cache(maxsize=100)
def _get_netloc(url: str) -> str:
Expand Down Expand Up @@ -187,6 +191,10 @@ def get_bundle(self, bundle_name):
time.sleep(self.config["POLL_INTERVAL"])
if timeout and (time.time() - timeout > start):
timed_out = True
if not timeout:
warn(
message=_LOADER_POSSIBLE_LIMBO, category=RuntimeWarning
)
assets = self.get_assets()

if timed_out:
Expand Down