Added select widget for bs4 form#21
Open
smithdc1 wants to merge 1 commit intodjango-crispy-forms:mainfrom
Open
Added select widget for bs4 form#21smithdc1 wants to merge 1 commit intodjango-crispy-forms:mainfrom
smithdc1 wants to merge 1 commit intodjango-crispy-forms:mainfrom
Conversation
Member
|
Ha! Two days ago I did the same (with Bootstrap3 as well): cpina@544da33 And then somehow I realised that we had a select (even with the arrow): But perhaps we should just add the simple select for clarity. |
Member
Author
|
Let's merge your version? I think explicit is better here, it's probably due to it not being on its own we've 'missed' it before? |
Member
|
Last night with one my fixes it initially worked with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


@cpina re your note that the select widget isn't quite right.