Skip to content

Conversation

@8de2fdb0
Copy link

@8de2fdb0 8de2fdb0 commented Jul 7, 2025

Adds the extendable flag for the updated slip39 spec.

Allows for resharable secrets, references:

@alvroble this might be also of interest to you.

@alvroble
Copy link

alvroble commented Jul 7, 2025

Thanks @8de2fdb0! Is nice to have this feature updated, I completely overlooked it.

Maybe it's a topic for a different PR, but I suspect (couldn't verify) that the generate_shares function is also cryptographically incorrect (similar to recover_mnemonic, as discussed in #90) and we would be getting a completely different wallet. According to the SLIP-0039 spec, we should't be recovering from the secret that mnemonic_to_bytes returns, but from the 512-bit seed, which would result in 59-word shares.

I'm planning to set up a PR once I find some clearance on this issue.

@alvroble
Copy link

alvroble commented Jul 7, 2025

Said that, for now I think is good to have two separate approach to generate shares: generate_shares_from_secret and generate_shares (from bip39 mnemonic)

@8de2fdb0
Copy link
Author

8de2fdb0 commented Jul 8, 2025

Yes the idea of generate_shares_from_secret was to stay backward compatible, but actually use a bip32 seed in byte format. As explained in #90 using the bip39 mnemonic as input is a bit misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants