Skip to content

fix: treefmt on nixos-unstable#398

Merged
blaggacao merged 2 commits intodivnix:mainfrom
dantefromhell:patch-1
May 13, 2025
Merged

fix: treefmt on nixos-unstable#398
blaggacao merged 2 commits intodivnix:mainfrom
dantefromhell:patch-1

Conversation

@dantefromhell
Copy link
Contributor

nixpkgs@dcb250a introduced some changes to the treefmt package:

  • the treefmt package is treefmt v2 aka the go version)
  • the treefmt1 package throws an eval error

resulting in broken std devens as they trigger the eval error for treefmt1.

std@febf2ee explicitly selects the discontinued rust implementation due to unfixed bugs in 24.11 for treefmt < 2.1.1.

The std repo still uses the 23.11 nixpkgs release.

@blaggacao I'm not sure what the best path forward is for this change to not break backwards compatibility, please advise.

Until this is sorted I'll leave this PR as draft for further discussion.

@blaggacao
Copy link
Collaborator

Is there any need to switch to the new packages, while the old is still in nixpkgs? My reasoning is that once the new is a full and equal replacement, the old one will be removed and this code will just continue to wirk fine.

@korrat
Copy link

korrat commented Apr 11, 2025

With current nixpkgs-unstable, the lines in question evaluate to an error pointing out the removal of treefmt1.

This is especially problematic for the treefmt configuration preset because it cannot be overriden easily.

@blaggacao
Copy link
Collaborator

Ok, then let's switch to nixpkgs.treefmt, in that case, an hope the treefmt rewrite is stable and bug-free, now.

@oneingan
Copy link
Contributor

plan to merge this?

@dantefromhell dantefromhell marked this pull request as ready for review April 27, 2025 23:45
@dantefromhell
Copy link
Contributor Author

Apologies for the delay and thanks @blaggacao for making the call.

I've marked the PR as ready to review.

@blaggacao blaggacao merged commit 42c65f3 into divnix:main May 13, 2025
9 of 10 checks passed
@blaggacao
Copy link
Collaborator

blaggacao commented May 13, 2025

Let's go, then! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants