This repository was archived by the owner on Jul 4, 2024. It is now read-only.
Added methods for adding cards to and deleting cards from user accounts.#9
Open
lennartvava wants to merge 4 commits intodevelopfrom
Open
Added methods for adding cards to and deleting cards from user accounts.#9lennartvava wants to merge 4 commits intodevelopfrom
lennartvava wants to merge 4 commits intodevelopfrom
Conversation
dhaemer
approved these changes
Aug 22, 2017
Jelle-S
approved these changes
Aug 23, 2017
zero2one
suggested changes
Aug 23, 2017
| { | ||
| $static = new static(); | ||
|
|
||
| foreach ($stringLiterals as $propertyName => $propertyValue) { |
There was a problem hiding this comment.
Beter om deze hardcoded in de code te zetten (magic is evil):
$static->library = StringLiteral::create($stringLiterals['library']);
$static->barcode = StringLiteral::create($stringLiterals['barcode']);
$static->verification = StringLiteral::create($stringLiterals['verification']);
$static->logSessionId = StringLiteral::create($stringLiterals['logSessionId']);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.