Open
Conversation
devsnek
reviewed
Sep 17, 2020
devsnek
reviewed
Sep 17, 2020
Author
|
Updated to requested changes, however there is just a nit - the |
|
Shouldn't |
Author
thats what i thought, but #90 (comment) |
5ab576b to
36de77d
Compare
Contributor
|
Could throw in an index.d.ts while you're at it. |
Author
see #89 (comment) snek doesn't want typings in the library itself |
noftaly
reviewed
Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds some better documentation, corrects some invalid syntax in the JSDoc comments, and deprecates
RPCClient#sendJoinRequestas the command has been removedthis PR only changes documentation
reference: this pr is apart of the chain of prs requested from #89 (comment)