feat: Added 'Max Cap Timeout' for help channels#72
Open
Ngoc-Cac wants to merge 4 commits intodiscord-math:mainfrom
Open
feat: Added 'Max Cap Timeout' for help channels#72Ngoc-Cac wants to merge 4 commits intodiscord-math:mainfrom
Ngoc-Cac wants to merge 4 commits intodiscord-math:mainfrom
Conversation
Added a feature where a channel cannot stay open past a specified amount of time. The default value for cap is 3 days, but may be changed by configuration. The command for configuration is '.config clopen <server id> timeout_cap [duration]' This is tested locally with different amount of times ranging from a few minutes to an hour. I did not test for larger values since I was impatient. But it should still work. More specifications: Upon closing, a reason for closing will be given "Channel closed due to maximum timeout reached!". The user is not however pinged as this is an embedded message. When closed, the channel will be archived (moved to hidden help channel category in the server).
Author
|
Oh and about the pinging thing, I think maybe after the closing notice, we could have the bot send a message where it actually pings the channel owner. But I'm not sure if this is necessary anyway. |
Forgot to run pyright so ran it and updated with type-checking. Also forgot the case where a channel is made pending right before the timeout_cap is reached.
Refactored the code for closing channel due to maximum timeout reached. Condensed the whole procedure of closing a channel due to max timeout reached into a function called `timeout_cap_close_procedure` Fixed condition checking: Fixed the condition checking in `scheduler_task`. The structure should be if-elif instead of if-if when checking conditions for max_expiry and expiry.
README: added instructions for configuring the maximum timeout (timeout_cap) Close procedure: Added pinging user after closing the channel. I thought it might be unnecessary. But maybe this helps the owner find their channel more easily,.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a feature where a channel cannot stay open past a specified amount of time. The default value for cap is 3 days, but may be changed by configuring clopen. The command for configuration is:
.config clopen <server id> timeout_cap [duration]This is tested locally with different amount of times ranging from a few minutes to an hour. I did not test for larger values since I was impatient. But it should still work.
More specifications:
Upon closing, a reason for closing will be given: "Channel closed due to maximum timeout reached!". The user is not, however, pinged as this is an embedded message. When closed, the channel will be archived (moved to hidden help channel category in the server).
Preview of closing notice: