Show human-readable reason for LDAP bind failures#80
Open
omershaik0 wants to merge 1 commit intodirkjanm:masterfrom
Open
Show human-readable reason for LDAP bind failures#80omershaik0 wants to merge 1 commit intodirkjanm:masterfrom
omershaik0 wants to merge 1 commit intodirkjanm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an LDAP bind fails due to an AcceptSecurityContext error, Active Directory embeds a sub-status code in the error message (e.g., data 52e). Currently, only the raw ldap3 result dict
is printed, which isn't helpful mid-engagement when you need to quickly know whether you have the wrong password, a locked account, or an expired one.
This change parses the data XXXX hex sub-status code out of the bind error message and maps it to a human-readable reason before printing the existing raw result.
Before:
After:
The raw result is still printed unchanged, so nothing is hidden. If the sub-status code isn't in the map or isn't present in the message, behavior is identical to before.