Skip to content

Added LDAP Channel Binding Support#57

Open
deadjakk wants to merge 3 commits intodirkjanm:masterfrom
deadjakk:master
Open

Added LDAP Channel Binding Support#57
deadjakk wants to merge 3 commits intodirkjanm:masterfrom
deadjakk:master

Conversation

@deadjakk
Copy link
Copy Markdown

I ran into this on a recent engagement and thought I would push it upstream since I would be willing to bet ldap channel binding is going to be popping up more and more.

Tested working 👍

@jkter
Copy link
Copy Markdown

jkter commented Apr 3, 2024

Thank you for this PR! I used it during my assessment and it worked well.

@dirkjanm Could be this PR merged? I find it very useful.

@Zamanry
Copy link
Copy Markdown

Zamanry commented Apr 29, 2024

I noticed that the flag --ldap-channel-binding does not appear in the options:
image

The error is expected, but this shows that the flag does exist:
image

@Zamanry
Copy link
Copy Markdown

Zamanry commented Apr 29, 2024

Nevermind. I installed ly4k's ldap3 library and then the parameter appeared. Was not aware this was even possible. Worked like a charm. Thanks!

@cmprmsd
Copy link
Copy Markdown

cmprmsd commented May 31, 2024

Can confirm it's working well 👍

@spextat0r
Copy link
Copy Markdown

Bumping this as it still works in 2025. For anyone who stumbles on this and wants it with the latest version of ldapdomaindump with the updates that have been added since this PR was made I forked it and added deadjakk’s code.

@moscowchill
Copy link
Copy Markdown

Why did he not merge this??

@spextat0r
Copy link
Copy Markdown

Why did he not merge this??

No idea however ly4k’s ldap3 library is now archived and the official ldap3 repo has support for ldaps and channel binding now (at least its shown within their documentation on pypi idk if the implementation is out yet) https://ldap3.readthedocs.io/en/latest/connection.html

@moscowchill
Copy link
Copy Markdown

Why did he not merge this??

No idea however ly4k’s ldap3 library is now archived and the official ldap3 repo has support for ldaps and channel binding now (at least its shown within their documentation on pypi idk if the implementation is out yet) https://ldap3.readthedocs.io/en/latest/connection.html

Thanks! I implemented the official ldap3 libs channel bindin and submitted a new PR.

@Neustradamus
Copy link
Copy Markdown

@deadjakk: Nice, thanks for your PR about TLS Channel Binding!

@moscowchill has done a new PR about it too:

Linked to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants