Add env override for Add/Manage License button#27779
Conversation
… with default true" This reverts commit a8e353f.
…eLicense function
| : getDirectusUrlWithUtm(DIRECTUS_PRICING_URL, serverStore.info.version, 'settings_license_upgrade_plan_link'), | ||
| ); | ||
|
|
||
| const manageLicenseDisabledMessage = computed(() => { |
There was a problem hiding this comment.
Any context for showing env managed if general management is off?
I would expect messaging should depend on whether management is enabled. If management is disabled, we should show that license management is not allowed. If management is enabled but the source is env, then we can show the env message.
As a side note, this also does not show the env manage message if license is enabled but source is env
There was a problem hiding this comment.
There wasn't originally, but now with how the editable is worked out on the backend it makes sense to show them this way otherwise when the edit is restricted purely by the env license, the frontend can't tell and will show “Management of your license key is disabled by your environment settings”
There was a problem hiding this comment.
I see no issue showing "Management of your license key is disabled by your environment settings” irrespective of license source or existing license?
| const { info: license, addons, loading, boundary, isLicensed } = storeToRefs(licenseStore); | ||
|
|
||
| const isEnvManaged = computed(() => license.value?.source === 'env'); | ||
| const isLicenseManageLinkEnabled = computed(() => licenseStore.info?.editable); |
There was a problem hiding this comment.
Let's rename this inline with any rename to the env var for clarity
There was a problem hiding this comment.
renamed to isLicenseKeyManagementEnabled
Co-authored-by: judda <44623501+ComfortablyCoding@users.noreply.github.com>
Scope
What's changed:
Potential Risks / Drawbacks
Tested Scenarios
Manually tested across all these states and backed up by Claude
Before
After
Review Notes / Questions
Checklist
Fixes cms-2721