Skip to content

Conversation

@terrier989
Copy link
Member

@terrier989 terrier989 commented Nov 16, 2025

  • Improves CI pipeline.
  • Adds "package:universal_html/universal_html.dart" to prepare for new import syntax in Dart. Deprecates "package:universal_html/html.dart".
  • Formats files.
  • Improves documentation.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the universal_html package for new Dart import syntax by introducing a new package:universal_html/universal_html.dart library entry point and deprecating the old html.dart import. It also includes CI/CD improvements, code formatting, and documentation updates for version 2.2.7.

  • Version bump from 2.2.5 to 2.2.7
  • Introduction of new lib/universal_html.dart library file with conditional exports
  • Deprecation of lib/html.dart in favor of the new import path
  • Enhanced CI pipeline with formatting checks, linting, package health analysis, and browser testing
  • Code formatting throughout the codebase using Dart formatter
  • Removal of web and universal_io dependency updates

Reviewed Changes

Copilot reviewed 42 out of 49 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
pubspec.yaml Version bump to 2.2.7, SDK constraint changed to ^3.6.0, updated lints range, removed web dependency, updated universal_io version
test_in_flutter/pubspec.yaml Updated SDK constraint to >=3.0.0, removed lints version constraint
lib/universal_html.dart New library file providing the main entry point with conditional exports for browser/VM
lib/html.dart Deprecated in favor of universal_html.dart, now simply re-exports it
lib/src/html.dart Updated import to use new universal_html.dart path, removed library comment, added blank lines between part directives
lib/src/parsing/parsing.dart Reordered imports, formatting improvements
README.md Updated import examples to use new universal_html.dart path, version references updated
CHANGELOG.md Added entries for versions 2.2.7 and 2.2.6
.github/workflows/dart.yml Comprehensive CI improvements: added formatting check, linting across SDK versions, package health analysis, and Chrome browser tests
.github/workflows/publish.yml New workflow for automated publishing to pub.dev
.github/FUNDING.yml Removed funding configuration
lib/src/html/dom/*.dart Formatting improvements: constructor initializer list alignment, cascade operator alignment
lib/src/html/api/*.dart Formatting improvements: constructor initializer list alignment, blank lines added between abstract methods
lib/src/controller/*.dart Formatting improvements: import alignment, parameter formatting
test/src/html/dom/*.dart Formatting improvements: cascade operator and initializer list alignment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@terrier989 terrier989 force-pushed the fix/various_issues branch 2 times, most recently from 1984606 to 9542f14 Compare November 16, 2025 20:47
Copilot AI review requested due to automatic review settings November 16, 2025 20:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 42 out of 49 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


environment:
sdk: ^3.7.0
sdk: ^3.6.0
Copy link

Copilot AI Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The SDK version constraint has been changed from ^3.7.0 to ^3.6.0, which is a downgrade. This seems inconsistent with the PR's goal of improving the codebase. If this is intentional to support older Dart SDK versions, it should be documented in the changelog or PR description.

Copilot uses AI. Check for mistakes.
os: [ubuntu-latest]
sdk: [stable, beta, dev]
steps:
- uses: actions/checkout@v3
Copy link

Copilot AI Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The workflow uses actions/checkout@v3, but the latest major version is v4. Consider upgrading to actions/checkout@v4 for the latest features and bug fixes.

Copilot uses AI. Check for mistakes.
@terrier989 terrier989 merged commit b294281 into master Nov 16, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants