-
Notifications
You must be signed in to change notification settings - Fork 71
Fixes various issues #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes various issues #110
Conversation
d98be7f to
73422d3
Compare
73422d3 to
46a6c93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares the universal_html package for new Dart import syntax by introducing a new package:universal_html/universal_html.dart library entry point and deprecating the old html.dart import. It also includes CI/CD improvements, code formatting, and documentation updates for version 2.2.7.
- Version bump from 2.2.5 to 2.2.7
- Introduction of new
lib/universal_html.dartlibrary file with conditional exports - Deprecation of
lib/html.dartin favor of the new import path - Enhanced CI pipeline with formatting checks, linting, package health analysis, and browser testing
- Code formatting throughout the codebase using Dart formatter
- Removal of
webanduniversal_iodependency updates
Reviewed Changes
Copilot reviewed 42 out of 49 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Version bump to 2.2.7, SDK constraint changed to ^3.6.0, updated lints range, removed web dependency, updated universal_io version |
| test_in_flutter/pubspec.yaml | Updated SDK constraint to >=3.0.0, removed lints version constraint |
| lib/universal_html.dart | New library file providing the main entry point with conditional exports for browser/VM |
| lib/html.dart | Deprecated in favor of universal_html.dart, now simply re-exports it |
| lib/src/html.dart | Updated import to use new universal_html.dart path, removed library comment, added blank lines between part directives |
| lib/src/parsing/parsing.dart | Reordered imports, formatting improvements |
| README.md | Updated import examples to use new universal_html.dart path, version references updated |
| CHANGELOG.md | Added entries for versions 2.2.7 and 2.2.6 |
| .github/workflows/dart.yml | Comprehensive CI improvements: added formatting check, linting across SDK versions, package health analysis, and Chrome browser tests |
| .github/workflows/publish.yml | New workflow for automated publishing to pub.dev |
| .github/FUNDING.yml | Removed funding configuration |
| lib/src/html/dom/*.dart | Formatting improvements: constructor initializer list alignment, cascade operator alignment |
| lib/src/html/api/*.dart | Formatting improvements: constructor initializer list alignment, blank lines added between abstract methods |
| lib/src/controller/*.dart | Formatting improvements: import alignment, parameter formatting |
| test/src/html/dom/*.dart | Formatting improvements: cascade operator and initializer list alignment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1984606 to
9542f14
Compare
9542f14 to
27f0fdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 42 out of 49 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| environment: | ||
| sdk: ^3.7.0 | ||
| sdk: ^3.6.0 |
Copilot
AI
Nov 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The SDK version constraint has been changed from ^3.7.0 to ^3.6.0, which is a downgrade. This seems inconsistent with the PR's goal of improving the codebase. If this is intentional to support older Dart SDK versions, it should be documented in the changelog or PR description.
| os: [ubuntu-latest] | ||
| sdk: [stable, beta, dev] | ||
| steps: | ||
| - uses: actions/checkout@v3 |
Copilot
AI
Nov 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The workflow uses actions/checkout@v3, but the latest major version is v4. Consider upgrading to actions/checkout@v4 for the latest features and bug fixes.
Uh oh!
There was an error while loading. Please reload this page.