fix: add missing type property for thinking effort conflict rectifier#1270
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
…mSettingsInput type The property was used in src/actions/system-config.ts and src/repository/system-config.ts but missing from the type definition, causing TS2339/TS2353 errors in CI. CI Run: https://github.com/ding113/claude-code-hub/actions/runs/27326760885 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Auto-Fix
Original PR: #1269
Failed CI Run: Non-Main Branch CI/CD
Fixes Applied
src/types/system-config.tsenableThinkingEffortConflictRectifier?: booleantoUpdateSystemSettingsInputinterfaceRoot Cause
The new feature added usage of
enableThinkingEffortConflictRectifierinsrc/actions/system-config.ts(line 129) andsrc/repository/system-config.ts(lines 760-761), but the property was not added to theUpdateSystemSettingsInputtype definition insrc/types/system-config.ts.Verification
tsgo -p tsconfig.json --noEmitpassesbiome checkpassesAuto-generated by Claude AI
Greptile Summary
This auto-generated PR adds a single missing optional property
enableThinkingEffortConflictRectifier?: booleanto theUpdateSystemSettingsInputinterface insrc/types/system-config.ts, resolving a TypeScript compilation error introduced by the parent feature branch.boolean) in theSystemSettingsinterface and used across the repository (repository layer, actions, cache, API schema), but was omitted from the update-input type.enableThinkingBudgetRectifierandenableBillingHeaderRectifier, matching the ordering inSystemSettings. No logic changes are made.Confidence Score: 5/5
Safe to merge — single additive change to a type definition with no logic modifications.
The change adds one optional boolean property to an input interface, matching the pattern of every other rectifier flag already present. The property is already fully wired in the action, repository, cache, API schema, DB schema, and UI — this type fix was the only missing piece that blocked compilation. No behaviour is altered.
No files require special attention.
Important Files Changed
enableThinkingEffortConflictRectifier?: booleantoUpdateSystemSettingsInput; placement and optionality are correct and consistent with sibling fields.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["Client / UI Form\nsystem-settings-form.tsx"] -->|"UpdateSystemSettingsInput\n(now includes enableThinkingEffortConflictRectifier)"| B["Server Action\nsrc/actions/system-config.ts"] B -->|"validated payload"| C["Repository\nsrc/repository/system-config.ts"] C -->|"DB write"| D["Drizzle Schema\nenable_thinking_effort_conflict_rectifier column"] C -->|"read → transform"| E["SystemSettings\n(enableThinkingEffortConflictRectifier: boolean)"] E -->|"used at runtime"| F["Proxy Forwarder\nforwarder.ts: strips reasoning_effort on conflict"]Reviews (1): Last reviewed commit: "fix: add missing enableThinkingEffortCon..." | Re-trigger Greptile