Skip to content

fix: add missing type property for thinking effort conflict rectifier#1270

Open
github-actions[bot] wants to merge 1 commit into
feat/thinking-effort-conflict-rectifierfrom
claude-fix-pr-1269-27326760885
Open

fix: add missing type property for thinking effort conflict rectifier#1270
github-actions[bot] wants to merge 1 commit into
feat/thinking-effort-conflict-rectifierfrom
claude-fix-pr-1269-27326760885

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

CI Auto-Fix

Original PR: #1269
Failed CI Run: Non-Main Branch CI/CD

Fixes Applied

File Fix Type
src/types/system-config.ts Added enableThinkingEffortConflictRectifier?: boolean to UpdateSystemSettingsInput interface TypeScript missing property

Root Cause

The new feature added usage of enableThinkingEffortConflictRectifier in src/actions/system-config.ts (line 129) and src/repository/system-config.ts (lines 760-761), but the property was not added to the UpdateSystemSettingsInput type definition in src/types/system-config.ts.

Verification

  • tsgo -p tsconfig.json --noEmit passes
  • biome check passes
  • No logic changes made - only added the missing type property

Auto-generated by Claude AI

Greptile Summary

This auto-generated PR adds a single missing optional property enableThinkingEffortConflictRectifier?: boolean to the UpdateSystemSettingsInput interface in src/types/system-config.ts, resolving a TypeScript compilation error introduced by the parent feature branch.

  • The property was already defined as required (boolean) in the SystemSettings interface and used across the repository (repository layer, actions, cache, API schema), but was omitted from the update-input type.
  • The fix is placed in the correct position between enableThinkingBudgetRectifier and enableBillingHeaderRectifier, matching the ordering in SystemSettings. No logic changes are made.

Confidence Score: 5/5

Safe to merge — single additive change to a type definition with no logic modifications.

The change adds one optional boolean property to an input interface, matching the pattern of every other rectifier flag already present. The property is already fully wired in the action, repository, cache, API schema, DB schema, and UI — this type fix was the only missing piece that blocked compilation. No behaviour is altered.

No files require special attention.

Important Files Changed

Filename Overview
src/types/system-config.ts Adds missing enableThinkingEffortConflictRectifier?: boolean to UpdateSystemSettingsInput; placement and optionality are correct and consistent with sibling fields.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Client / UI Form\nsystem-settings-form.tsx"] -->|"UpdateSystemSettingsInput\n(now includes enableThinkingEffortConflictRectifier)"| B["Server Action\nsrc/actions/system-config.ts"]
    B -->|"validated payload"| C["Repository\nsrc/repository/system-config.ts"]
    C -->|"DB write"| D["Drizzle Schema\nenable_thinking_effort_conflict_rectifier column"]
    C -->|"read → transform"| E["SystemSettings\n(enableThinkingEffortConflictRectifier: boolean)"]
    E -->|"used at runtime"| F["Proxy Forwarder\nforwarder.ts: strips reasoning_effort on conflict"]
Loading

Reviews (1): Last reviewed commit: "fix: add missing enableThinkingEffortCon..." | Re-trigger Greptile

…mSettingsInput type

The property was used in src/actions/system-config.ts and
src/repository/system-config.ts but missing from the type definition,
causing TS2339/TS2353 errors in CI.

CI Run: https://github.com/ding113/claude-code-hub/actions/runs/27326760885

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

0 participants