release v0.8.4 #1243
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -12,7 +12,7 @@ ENV NEXT_TELEMETRY_DISABLED=1 | |||||
| ENV CI=true | ||||||
| RUN --mount=type=cache,target=/app/.next/cache bun run build | ||||||
|
|
||||||
| FROM node:22-slim AS runner | ||||||
|
There was a problem hiding this comment.
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: Dockerfile
Line: 15
Comment:
`node:22-slim` is a rolling tag that can resolve to any 22.x patch release. The `zstdDecompressSync` API (used in `request-body-codec.ts`) was first shipped in Node 22.15.0. If this image is built against a stale Docker cache that points to an earlier 22.x build, the decompression call will fail at runtime with `TypeError: zstdDecompressSync is not a function`. Pinning to `node:22.15-slim` (or later) makes the minimum requirement explicit and matches what `package.json` `engines` already declares.
```suggestion
FROM node:22.15-slim AS runner
```
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment. 🧩 Analysis chain🌐 Web query:
💡 Result: 是的，Node 官方 Docker 镜像提供 Citations:
建议将运行时基础镜像固定到精确补丁版本，避免使用漂移标签（Dockerfile 第15行：
🤖 Prompt for AI Agents
Contributor
There was a problem hiding this comment. [Medium] [STANDARD-VIOLATION] Rolling Docker tag doesn't guarantee the minimum Node version required by
The Suggested fix: FROM node:22.15-slim AS runner |
||||||
| WORKDIR /app | ||||||
| ENV NODE_ENV=production | ||||||
| ENV PORT=3000 | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -253,6 +253,14 @@ export async function createRequestFilterAction(data: { | |
| operations: data.operations ?? null, | ||
| }); | ||
|
|
||
| // 立即同步内存缓存，确保新规则对代理请求即时生效，无需用户手动点"刷新缓存"。 | ||
| // 仓储层已在写入后触发一次本进程 reload，这里 reload(false) 复用它（不补跑第二轮）； | ||
| // reload 仅为缓存同步，失败不应把已成功的写入误报为失败。 | ||
| try { | ||
| await requestFilterEngine.reload(false); | ||
| } catch (reloadError) { | ||
| logger.warn("[RequestFiltersAction] Failed to reload engine after create", { reloadError }); | ||
| } | ||
| revalidatePath(SETTINGS_PATH); | ||
| return { ok: true, data: created }; | ||
| } catch (error) { | ||
|
|
@@ -378,6 +386,14 @@ export async function updateRequestFilterAction( | |
| return { ok: false, error: "记录不存在" }; | ||
| } | ||
|
|
||
| // 立即同步内存缓存，确保规则改动对代理请求即时生效，无需用户手动点"刷新缓存"。 | ||
| // 仓储层已在写入后触发一次本进程 reload，这里 reload(false) 复用它（不补跑第二轮）； | ||
| // reload 仅为缓存同步，失败不应把已成功的写入误报为失败。 | ||
| try { | ||
| await requestFilterEngine.reload(false); | ||
| } catch (reloadError) { | ||
| logger.warn("[RequestFiltersAction] Failed to reload engine after update", { reloadError }); | ||
| } | ||
| revalidatePath(SETTINGS_PATH); | ||
| return { ok: true, data: updated }; | ||
| } catch (error) { | ||
|
|
@@ -393,6 +409,14 @@ export async function deleteRequestFilterAction(id: number): Promise<ActionResul | |
| try { | ||
| const ok = await deleteRequestFilter(id); | ||
| if (!ok) return { ok: false, error: "记录不存在" }; | ||
| // 立即同步内存缓存，确保删除对代理请求即时生效，无需用户手动点"刷新缓存"。 | ||
| // 仓储层已在写入后触发一次本进程 reload，这里 reload(false) 复用它（不补跑第二轮）； | ||
| // reload 仅为缓存同步，失败不应把已成功的写入误报为失败。 | ||
| try { | ||
| await requestFilterEngine.reload(false); | ||
| } catch (reloadError) { | ||
| logger.warn("[RequestFiltersAction] Failed to reload engine after delete", { reloadError }); | ||
| } | ||
| revalidatePath(SETTINGS_PATH); | ||
| return { ok: true }; | ||
| } catch (error) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
在 Node.js 官方文档中确认：node:zlib的 zstd 同步解压（如zstdDecompressSync）从哪个 Node 版本开始可用？Node 22.0.0 是否保证可用？💡 Result:
在 Node.js 中，
node:zlib模块提供的 Zstd 同步解压方法zstdDecompressSync是从 Node.js v22.15.0 版本开始可用的 [1][2]。 关于您询问的 Node 22.0.0 版本：该功能在 Node 22.0.0 中不可用 [2]。zstdDecompressSync直到后续的补丁版本 v22.15.0 才被正式加入到 API 中 [1][2]。如果您需要在 Node 22.x 系列中使用此功能，请确保您的 Node.js 版本至少升级到 v22.15.0 或更高版本。Citations:
CI Node 版本应固定到明确下限（22.15.x）
当前
.github/workflows/pr-check.yml将node-version固定为"22"，可能解析到 22.15.0 之前的 22.x；而node:zlib的zstdDecompressSync需要至少 Node.js v22.15.0 才提供（22.0.0 不包含该能力）。为避免 CI 运行时漂移，建议固定到22.15.x（或更高）。建议修改
🤖 Prompt for AI Agents