Fix oversized dispatch#4
Merged
Merged
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several per-particle compute kernels dispatch
ceil(n_particles / workgroup_size)workgroups along a single (X) dimension. Once the particle count exceeds
~4.19M (
65535 * 64), this exceeds the WebGPU / Vulkan / D3D12 maximum number ofworkgroups per dimension, and the simulation aborts with a validation error:
Fix
Clamp the dispatch to at most
MAX_NUM_WORKGROUPS(65535) using the existingGpuFunction::launch_capped, and grid-stride over the particles inside eachaffected kernel so every input is still processed:
Affected kernels:
touch_particle_blocks,update_block_particle_count,finalize_particles_sortparticle_update,estimate_timestep_boundTesting
cargo check -p slosh3d --features dim3,runtimepasses.previously panicked ~3s in with the error above; now runs to completion and
produces correct output.
so results are unchanged (verified output matches the pre-fix build within
run-to-run convergence noise).