Fix user-change handling for colliders as well as disabled colliders #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D to ::IN_MODIFIED_SET
…bled dynamic rigid-bodies
This was referenced Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ColliderChanges::CHANGEDto::IN_CHANGED_SETto make its meaning more precise.RigidBodyChanges::CHANGEDto::IN_CHANGED_SETto make its meaning more precise.This replaces #894 and #898 which are both partial fixes for the issue but with some undesired side-effects.
This should solve dimforge/rapier.js#344 too.
Close #894
Close #848
Fix #897