Fix T: Sync bound of impl Send for ViewStorage#1581
Merged
sebcrozet merged 1 commit intodimforge:mainfrom Jan 4, 2026
Merged
Conversation
Ralith
approved these changes
Jan 4, 2026
Collaborator
Ralith
left a comment
There was a problem hiding this comment.
Thanks! I won't merge this personally so it doesn't catch @sebcrozet by surprise, but we should definitely take this for the next breaking release.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1001
Note that this is a breaking change. The precondition differs between
ViewStorageandViewStorageMutjust like they differ between&mut Tand& T. While both allow reborrowing a&Tfrom a shared reference to them, i.e. they have the same requirements for theirSyncimplementations, the formalism is different for theSendtrait:SendwhereT: Send.SendwhereT: Sync.See: https://doc.rust-lang.org/stable/std/primitive.reference.html#trait-implementations-1