Fix grammar to accept numbers without leading zeros, e.g. ".45"#1578
Merged
alexhroom merged 1 commit intodimforge:mainfrom Dec 23, 2025
Merged
Fix grammar to accept numbers without leading zeros, e.g. ".45"#1578alexhroom merged 1 commit intodimforge:mainfrom
alexhroom merged 1 commit intodimforge:mainfrom
Conversation
Many matrices of the matrix market are are parsed incorrectly because of the missing leading zero. Example: <https://sparse.tamu.edu/Grund/b1_ss> ``` %%MatrixMarket matrix coordinate real general %------------------------------------------------------------------------------- % UF Sparse Matrix Collection, Tim Davis % http://www.cise.ufl.edu/research/sparse/matrices/Grund/b1_ss % name: Grund/b1_ss % [Unsymmetric Matrix b1_ss, F. Grund, Dec 1994.] % id: 449 % date: 1997 % author: F. Grund % ed: F. Grund % fields: title A b name id date author ed kind % kind: chemical process simulation problem %------------------------------------------------------------------------------- 7 7 15 5 1 -.03599942 6 1 -.0176371 7 1 -.007721779 1 2 1 2 2 -1 1 3 1 3 3 -1 1 4 1 4 4 -1 2 5 .45 5 5 1 3 6 .1 6 6 1 4 7 .45 7 7 1 ``` And the .45 and the .1 are not being read. Note that ../../nalgebra-sparse/src/io/matrix_market.pest is correct. Also: `".45".parse::<f64>()` works.`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many matrices of the matrix market are being parsed incorrectly because of the missing leading zero.
Example: https://sparse.tamu.edu/Grund/b1_ss
And the .45 and the .1 are not being read.
Note that ../../nalgebra-sparse/src/io/matrix_market.pest is correct.
Also:
".45".parse::<f64>()works.`