Open
Conversation
Contributor
adamnemecek
commented
Jan 5, 2025
adamnemecek
commented
- made OMatrix::sum faster by using add_assign
- use map on optionals where possible
- refactored partial_cmp
Ralith
requested changes
Jan 5, 2025
Collaborator
Ralith
left a comment
Ralith
left a comment
There was a problem hiding this comment.
Thanks, overall these are nice style improvements. For future reference, they'd be a lot easier to review if you grouped changes of the same kind into the same commit, and force-pushed when you discover an error rather than fixing it in a later commit.
src/lib.rs
Outdated
| } else { | ||
| None | ||
| } | ||
| a.partial_cmp(b).map(|ord| if ord.is_ge() { b } else { a }) |
Collaborator
There was a problem hiding this comment.
To avoid a change in behavior, this should be is_gt (and similar below)
Contributor
Author
There was a problem hiding this comment.
This is the correct behavior, is_ge == matches!(self, Greater) which is what was there before.
Collaborator
There was a problem hiding this comment.
That's incorrect. The "e" stands for "equals", as in "greater or equals". This is illustrated in the documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.