Update inverse.rs - improved code doc try_inverse_mut#1399
Open
tencek wants to merge 1 commit intodimforge:mainfrom
Open
Update inverse.rs - improved code doc try_inverse_mut#1399tencek wants to merge 1 commit intodimforge:mainfrom
tencek wants to merge 1 commit intodimforge:mainfrom
Conversation
The "and leaves `self` untouched" part of the code doc was wrong. Self may be modified before early false return.
Collaborator
Author
|
@Andlon - thank you for looking into this one and I apologize for my slow response. Fun fact: the unit test, including the values, was completely generated by the CoPilot. I just found the right place where to add the new test and was about to copy and paste the values I used in my software to replicate the issue. But the CoPilot was quicker and the values generated also replicated the bug. In the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "and leaves
selfuntouched" part of the code doc was wrong. Self may be modified before early false return.See https://github.com/dimforge/nalgebra/blob/dev/src/linalg/lu.rs#L64