Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal solution to #1391.
As discussed there, the current behaviour for allocating matrices is
- If too small, panic
- If too large, ignore remaining entries
- If too small, panic
- If too large and finite, panic
- If too large and infinite, loop indefinitely
This PR merely merges the last two cases and always panics with the same message:
- If too small, panic
- If too large, ignore remaining entries
- If too small, panic
- If too large, panic
I think it is highly unlikely that existing code relied on the infinite loop behaviour (which would most likely crash if the vec grew too big anyway), and therefore I think this can be safely merged without impacting any existing code. This leaves the decision as to what the desired behaviour would be for later.