dimos/core/docker_module.py (693 LOC) is a parallel ModuleProxyProtocol impl — DockerModuleProxy, DockerModuleConfig, DockerModuleInner — none of it extends NativeModule. Same in coordination: worker_manager_docker.py sits next to worker_manager_python.py doing largely the same thing, both wired up in module_coordinator.py:56.
bad arch to keep around. just delete it.
if/when we want docker support back, it goes in as a thin subclass of NativeModule that only overrides how the child process is launched (docker run instead of plain exec). image build / cache logic moves to a separate helper that NativeModule doesn't need to know about.
scope:
- delete
dimos/core/docker_module.py
- delete
dimos/core/coordination/worker_manager_docker.py
- drop
WorkerManagerDocker from module_coordinator.py:56
- delete
examples/docker_hello_world/
- two real consumers to migrate or hold:
dimos/manipulation/grasping/graspgen_module.py (GraspGenConfig(DockerModuleConfig)) and dimos/manipulation/pick_and_place_module.py (uses DockerModuleProxy)
related: #1266 — we still want unification; but delete this first to make sure we don't build upon it. (re-add as a NativeModule subclass instead of refactoring the parallel hierarchy in place). also #1082 (config system).
dimos/core/docker_module.py(693 LOC) is a parallelModuleProxyProtocolimpl —DockerModuleProxy,DockerModuleConfig,DockerModuleInner— none of it extendsNativeModule. Same in coordination:worker_manager_docker.pysits next toworker_manager_python.pydoing largely the same thing, both wired up inmodule_coordinator.py:56.bad arch to keep around. just delete it.
if/when we want docker support back, it goes in as a thin subclass of
NativeModulethat only overrides how the child process is launched (docker runinstead of plain exec). image build / cache logic moves to a separate helper that NativeModule doesn't need to know about.scope:
dimos/core/docker_module.pydimos/core/coordination/worker_manager_docker.pyWorkerManagerDockerfrommodule_coordinator.py:56examples/docker_hello_world/dimos/manipulation/grasping/graspgen_module.py(GraspGenConfig(DockerModuleConfig)) anddimos/manipulation/pick_and_place_module.py(usesDockerModuleProxy)related: #1266 — we still want unification; but delete this first to make sure we don't build upon it. (re-add as a NativeModule subclass instead of refactoring the parallel hierarchy in place). also #1082 (config system).