feat(viewer): click-to-engage overlay + restore click-to-nav#19
Merged
spomichter merged 5 commits intomainfrom Mar 18, 2026
Merged
feat(viewer): click-to-engage overlay + restore click-to-nav#19spomichter merged 5 commits intomainfrom
spomichter merged 5 commits intomainfrom
Conversation
PR #14's run_with_app_wrapper rewrote viewer.rs and dropped the on_event handler for click-to-navigate. This restores it properly: - Add StartupOptionsPatch struct to rerun entrypoint with on_event callback - Wire Ctrl+click -> PointStamped LCM on /clicked_point in viewer.rs - Arc<AtomicBool> for ctrl state sharing (Send required by AppWrapper) - 100ms debounce on nav goal publishing
spomichter
force-pushed
the
feat/click-engage-rebase
branch
from
b2997dc to
b8fdb08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebases Ruthwik's PR #13 onto current main (post-PR #14) and restores click-to-navigate that was accidentally dropped during the PR #18 rebase.
Changes
From Ruthwik (4 commits, authorship preserved)
Click-to-nav restore (1 commit)
StartupOptionsPatchstruct to rerun entrypoint withon_eventcallback injection/clicked_pointin viewer.rsArc<AtomicBool>for ctrl state sharing (Sendrequired byAppWrapper)Context
PR #14 rewrote
viewer.rsforrun_with_app_wrapperand PR #18 rebased #13 onto it, but the conflict resolution took--oursfor viewer.rs — silently dropping the click-to-nav handler. PR #18 has been reverted on main. This PR does the rebase properly.Testing