ansible-lint cleanup - part 1#6928
Merged
Merged
Conversation
{{x}} → {{ x }}, purely cosmetic
Replace 'when: x == True/False' with idiomatic 'when: x' / 'when: not x'
Replace `item.stdout != ""` with bare `item.stdout` truthiness
Names are diagnostic only; no behavior change.
Fixing these would require adding boilerplate to each role at
src/commcare_cloud/ansible/roles/<role>/meta/main.yml:
```yml
galaxy_info:
description: ...
author: Dimagi
license: BSD-3-Clause
min_ansible_version: "2.10"
platforms:
- name: Ubuntu
```
The benefit is not clear; looks like just more lines to maintain.
Roles can be updated if they are ever published to Ansible Galaxy.
AmitPhulera
approved these changes
Jul 1, 2026
AmitPhulera
left a comment
AmitPhulera
left a comment
Contributor
There was a problem hiding this comment.
Started looking good already.
Curious if you have done these manually or there is a formatter that fixes the auto-fixable problems?
Contributor
Author
There is no auto-fixer that I know of. I used Claude + manual edits. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the ongoing effort to upgrade Ansible and reduce the
.ansible-lint-ignorebacklog. This PR clears the low-risk, mechanical lint rules. Later PRs will handle similar riskier work.https://dimagi.atlassian.net/browse/SAAS-19980
🐡 Review by commit.
Environments Affected
None.