Skip to content

grahom.gi test coverage#928

Open
mtorpey wants to merge 3 commits intodigraphs:mainfrom
mtorpey:grahom-coverage
Open

grahom.gi test coverage#928
mtorpey wants to merge 3 commits intodigraphs:mainfrom
mtorpey:grahom-coverage

Conversation

@mtorpey
Copy link
Copy Markdown
Collaborator

@mtorpey mtorpey commented May 1, 2026

Nothing too controversial here, but this brings test coverage of grahom to 100%.

In case anyone's wondering: yes, this is more fun than marking.

@mtorpey mtorpey added minor A label for PRs or issues that are minor in some sense. tests A label for issues/PRs relating to adding or updating tests or the testing system labels May 1, 2026
@mtorpey mtorpey force-pushed the grahom-coverage branch from 0b06a53 to bdf3545 Compare May 1, 2026 13:22
Comment thread gap/grahom.gi Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.45%. Comparing base (7ba3ec4) to head (cf3c0d0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
+ Coverage   97.43%   97.45%   +0.02%     
==========================================
  Files          50       50              
  Lines       21193    21188       -5     
  Branches      639      639              
==========================================
  Hits        20649    20649              
+ Misses        479      474       -5     
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtorpey mtorpey force-pushed the grahom-coverage branch from bdf3545 to 26ae4e7 Compare May 6, 2026 10:37
@mtorpey
Copy link
Copy Markdown
Collaborator Author

mtorpey commented May 6, 2026

@james-d-mitchell – changed that error message back, hopefully all okay now.

@mtorpey
Copy link
Copy Markdown
Collaborator Author

mtorpey commented May 6, 2026

And fixed.

Curiously, this was caused by the error message wrapping over the word <src> so that the > was the first character on the second line. This means that the expected output in the .tst file was treated as run-on input and caused a syntax warning, even though it was generated by rewriteToFile!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor A label for PRs or issues that are minor in some sense. tests A label for issues/PRs relating to adding or updating tests or the testing system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants