Skip to content

Allow optional catch binding #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lgrosales wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

Allow optional catch binding #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default [...compat.extends("eslint:recommended"), {
SharedArrayBuffer: "readonly",
},

ecmaVersion: 2018,
ecmaVersion: 2019,
sourceType: "commonjs",
},

Expand Down
6 changes: 3 additions & 3 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ async function downloadDoctlWithFallback(requestedVersion, type, architecture) {
try {
core.info(`Attempting to download doctl v${requestedVersion}`);
return await downloadDoctl(requestedVersion, type, architecture);
} catch (error) {
} catch {
core.warning(`Failed to download requested version v${requestedVersion}, will try recent versions`);
}
}
Expand All @@ -89,7 +89,7 @@ async function downloadDoctlWithFallback(requestedVersion, type, architecture) {
const installPath = await downloadDoctl(version, type, architecture);
core.info(`Successfully downloaded doctl v${version}`);
return { installPath, version };
} catch (error) {
} catch {
core.warning(`Failed to download doctl v${version}, trying next version`);
continue;
}
Expand Down Expand Up @@ -134,7 +134,7 @@ Failed to retrieve latest version; falling back to: ${fallbackVersion}`);
const installPath = await downloadDoctl(version, process.platform, process.arch);
path = await tc.cacheDir(installPath, 'doctl', version);
actualVersion = version;
} catch (error) {
} catch {
// If the download fails (e.g., missing artifacts), try fallback versions
core.warning(`Failed to download doctl v${version}, trying fallback versions`);
const result = await downloadDoctlWithFallback(requestedVersion, process.platform, process.arch);
Expand Down
Loading