Skip to content

Filter out dataset-field and spec fields for correct download #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pooleycodes merged 2 commits into from
Mar 18, 2026
Merged

Filter out dataset-field and spec fields for correct download #1162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
672473a
filter out dataset-field and spec fields
pooleycodes Mar 17, 2026
d0bdc5b
remove logging
pooleycodes Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/middleware/common.middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,10 +448,11 @@ export const addDatabaseFieldToSpecification = (req, res, next) => {

export const filterOutSystemFields = (req, res, next) => {
const { specification } = req
const systemFields = ['organisation'] // Currentl only organisation is not a field we want to show
const systemFields = ['organisation'] // Currently only organisation is not a field we want to show

// Slightly odd filter of looking at fields from dataset_fields and spec fields in the filter out.
req.specification.fields = specification.fields.filter(
fieldObj => !systemFields.includes(fieldObj.field)
fieldObj => !systemFields.includes(fieldObj.field) && !systemFields.includes(fieldObj.datasetField)
)

next()
Expand Down
Loading