feat: add date as an option for field types#318
Conversation
achou11
left a comment
There was a problem hiding this comment.
Does there need to be some kind of encoding/decoding validation to ensure the value is a valid ISO string?
There was a problem hiding this comment.
Just to confirm: is it unnecessary/useless to (de)serialize values as date objects? My initial thought is that it doesn't make sense in our case because there's an IPC boundary that potentially doesn't handle that well (e.g. I don't think rpc-reflector handles dates)
It's pretty limited, but there are a couple of good doc fixtures: comapeo-schema/test/fixtures/good-docs-completed.js Lines 193 to 218 in d78ffe0 comapeo-schema/test/fixtures/good-docs-minimal.js Lines 53 to 69 in d78ffe0 |
|
There's no existing hooks for validating values in fields (tags in an observation / track) right now so I think we can put it off until it's on our roadmap.
Affirmative it is not necessary right now, we might do it later in the year but it's not on the TODO list right now. |
Closes #317
Adds
dateas a validtypefor Fields. Do we need good/bad docs for this? Didn't see anything for other types of fields.