feat: update and rename type exports#313
Merged
gmaclennan merged 1 commit intomainfrom Oct 21, 2025
Merged
Conversation
RangerMauve
approved these changes
Oct 21, 2025
Contributor
RangerMauve
left a comment
There was a problem hiding this comment.
Looks good overall. Are these changes in service to the new categories change?
Agree re Comapeo vs CoMapeo.
Member
Author
No, it's just that this has been bothering me for a while, and in particular when I was looking at your PR for comapeo-cloud, I wanted to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mapeotype exports toComapeonaming.Mapeotype exportsComapeoDocandComapeoValuetype exports to accept a parameter specifying the doc type (schema name).This should not include any breaking changes, only deprecating some type exports, and adding new ones with
Comapeonaming, and additional functionality of accepting a parameter to narrow the doc type.Note on naming: I have chosen
Comapeorather thanCoMapeo(lowercasem) because the capitalizedMinCoMapeois a branding decision and does not demarcate a word boundary, so, following Pascal Case and Camel Case conventions, as we do with other type names and variable names, I think it makes sense to keep themlowercase.