feat: decode with coreDiscoveryId as well as coreDiscoveryKey#267
Draft
gmaclennan wants to merge 1 commit intomainfrom
Draft
feat: decode with coreDiscoveryId as well as coreDiscoveryKey#267gmaclennan wants to merge 1 commit intomainfrom
gmaclennan wants to merge 1 commit intomainfrom
Conversation
gmaclennan
force-pushed
the
feat/core-discovery-id
branch
from
331e6f5 to
ab4547b
Compare
Allow decode to work when a coreDiscoveryId is passed, instead of coreDiscoveryKey to match an upstream change in the multi-core-indexer to use coreDiscoveryId rather than coreDiscoveryKey. This reduces a round-trip conversion from buffer to string, and will also facilitate sending entries between threads when we run indexing in a separate worker thread.
gmaclennan
force-pushed
the
feat/core-discovery-id
branch
from
ab4547b to
65113ab
Compare
gmaclennan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow decode to work when a coreDiscoveryId is
passed, instead of coreDiscoveryKey to match an
upstream change in the multi-core-indexer to use
coreDiscoveryId rather than coreDiscoveryKey. This
reduces a round-trip conversion from buffer to
string, and will also facilitate sending entries
between threads when we run indexing in a separate
worker thread.